Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "TextColor" or similar option for button #42

Closed
akamensky opened this issue Sep 2, 2018 · 1 comment
Closed

Add "TextColor" or similar option for button #42

akamensky opened this issue Sep 2, 2018 · 1 comment

Comments

@akamensky
Copy link
Contributor

New Gmail web client seems to differ from before in how it handles button shown in email.

In previous version the button text was shown colored in accordance with theme, but now it shows as:

screen shot 2018-09-02 at 7 23 04 pm

From what it looks new Gmail web client adds its own style that overrides the embedded CSS from hermes theme:

screen shot 2018-09-02 at 7 25 37 pm

This is fixable by adding inline CSS to the button color: white; (for example) to make it look as below:

screen shot 2018-09-02 at 7 25 03 pm

Or I think this could be fixed by doing what #3 suggests and inlining all CSS.

@akamensky
Copy link
Contributor Author

Closing since merged.

Thanks for such a nice package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant