Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Site Scripting vulnerability #181

Closed
jmaxallen opened this issue Oct 10, 2018 · 2 comments
Closed

Cross Site Scripting vulnerability #181

jmaxallen opened this issue Oct 10, 2018 · 2 comments
Labels

Comments

@jmaxallen
Copy link

I really like your theme. But our static code analysis found a security issue that would prevent us from using it! I'm sorry that I don't know JavaScript well enough to offer a quick PR.

Type             Severity   Line#   File
============================================================================================
Client_DOM_XSS   High       71      /website/themes/hugo-theme-learn/static/js/hugo-learn.js
@jmaxallen
Copy link
Author

I tried putting it in a simple encodeURI(), and it cleared it up! I'll create a pull request.
#182

@matalo33
Copy link
Contributor

Thank you!

@matalo33 matalo33 added the bug label Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants