Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomSheetDialog] Content clipping after orientation change. #2358

Closed
enginegl opened this issue Sep 3, 2021 · 3 comments
Closed

[BottomSheetDialog] Content clipping after orientation change. #2358

enginegl opened this issue Sep 3, 2021 · 3 comments

Comments

@enginegl
Copy link

enginegl commented Sep 3, 2021

Description:
This issue was introduced in 1.4.0. Bottom sheet width is not invalidated on orientation change without activity recreation.
When activity has configChanges=orientation attribute and BottomSheet has been initialized with screen width more than 640dp bottom sheet content width won't be invalidated after orientation change:

Demo project: https://github.com/enginegl/bottom-sheet-issue

Expected behavior:
Bottom sheet width should be invalidated on orientation changes according to maxWidth value and actual screen width after orientation change.

Android API version:
Any API version

Material Library version:
1.4.0

Device:
Android Emulator API 30, Samsung S21 Ultra, Pixel 4 XL, any other device

@enginegl enginegl added the bug label Sep 3, 2021
@drchen
Copy link
Contributor

drchen commented Oct 1, 2021

I cannot reproduce the issue on my end. Is this still reproducible with the latest library version? If so, can you provide a minimal reproducible example to help us debug? Thank you very much!

@enginegl
Copy link
Author

enginegl commented Oct 4, 2021

@drchen, thanks for looking into this.
I cannot reproduce this issue in a demo project after updating to 1.5.0-alpha04.

Do you have any insights about future stable version release date?
Thanks!

@drchen
Copy link
Contributor

drchen commented Nov 2, 2021

Hi, we are going to release 1.5.0 beta in a couple of weeks I think. The stable version should be available soon after beta.

I'll close the issue for now. : )

@drchen drchen closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants