Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit 35dee08

Browse files
author
Matt Goo
committed
chore: rename foundation.setDisabled -> foundation.updateDisabledStyle
1 parent 1bc6d77 commit 35dee08

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

packages/mdc-select/foundation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default class MDCSelectFoundation extends MDCFoundation {
5555
this.blurHandler_ = (evt) => this.handleBlur_(evt);
5656
}
5757

58-
setDisabled(disabled) {
58+
updateDisabledStyle(disabled) {
5959
const {DISABLED} = MDCSelectFoundation.cssClasses;
6060
if (disabled) {
6161
this.adapter_.addClass(DISABLED);

packages/mdc-select/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class MDCSelect extends MDCComponent {
5454

5555
set disabled(disabled) {
5656
this.nativeControl_.disabled = disabled;
57-
this.foundation_.setDisabled(disabled);
57+
this.foundation_.updateDisabledStyle(disabled);
5858
}
5959

6060
/**

test/unit/mdc-select/foundation.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,15 @@ function setupTest() {
5252
return {mockAdapter, foundation};
5353
}
5454

55-
test('#setDisabled to true calls adapter.setDisabled and adapter.addClass', () => {
55+
test('#updateDisabledStyle to true calls adapter.addClass', () => {
5656
const {mockAdapter, foundation} = setupTest();
57-
foundation.setDisabled(true);
57+
foundation.updateDisabledStyle(true);
5858
td.verify(mockAdapter.addClass(MDCSelectFoundation.cssClasses.DISABLED));
5959
});
6060

61-
test('#setDisabled to false calls adapter.setDisabled false and adapter.removeClass', () => {
61+
test('#updateDisabledStyle to false calls adapter.removeClass', () => {
6262
const {mockAdapter, foundation} = setupTest();
63-
foundation.setDisabled(false);
63+
foundation.updateDisabledStyle(false);
6464
td.verify(mockAdapter.removeClass(MDCSelectFoundation.cssClasses.DISABLED));
6565
});
6666

test/unit/mdc-select/mdc-select.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ test('#get/setSelectedIndex', () => {
106106
assert.equal(component.selectedIndex, 1);
107107
});
108108

109-
test('#get/setDisabled', () => {
109+
test('#get/set disabled', () => {
110110
const {component} = setupTest();
111111
assert.isFalse(component.disabled);
112112
component.disabled = true;
@@ -142,11 +142,11 @@ test('#set selectedIndex calls foundation.handleChange', () => {
142142
td.verify(component.foundation_.handleChange(), {times: 1});
143143
});
144144

145-
test('#set disabled calls foundation.setDisabled', () => {
145+
test('#set disabled calls foundation.updateDisabledStyle', () => {
146146
const {component} = setupTest();
147-
component.foundation_.setDisabled = td.func();
147+
component.foundation_.updateDisabledStyle = td.func();
148148
component.disabled = true;
149-
td.verify(component.foundation_.setDisabled(true), {times: 1});
149+
td.verify(component.foundation_.updateDisabledStyle(true), {times: 1});
150150
});
151151

152152
test('#initialSyncWithDOM sets the selected index if an option has the selected attr', () => {

0 commit comments

Comments
 (0)