Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit ee1c0db

Browse files
simonolynnmercier
authored andcommitted
fix(list): Respect BEM when outputting the base stylesheet. (#1799)
Fixes #1748.
1 parent 3e53614 commit ee1c0db

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

packages/mdc-list/mdc-list.scss

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,27 +21,22 @@
2121
@import "./mixins";
2222
@import "./variables";
2323

24-
// TODO(acdvorak): Find a way to remove parent .mdc-list and .mdc-list-group selectors; they violate BEM.
2524
.mdc-list,
2625
.mdc-list-group {
27-
@include mdc-list-divider-color($mdc-list-divider-color-light);
28-
2926
@include mdc-theme-dark {
3027
@include mdc-list-divider-color($mdc-list-divider-color-dark);
3128
}
3229
}
3330

31+
@at-root {
32+
@include mdc-list-divider-color($mdc-list-divider-color-light);
33+
}
34+
3435
// postcss-bem-linter: define list
3536

3637
.mdc-list {
3738
@include mdc-typography(subheading2);
38-
39-
// TODO(acdvorak): Find a way to remove parent .mdc-list selector; it violates BEM.
4039
@include mdc-list-item-primary-text-ink-color(text-primary-on-background);
41-
@include mdc-list-item-secondary-text-ink-color(text-secondary-on-background);
42-
@include mdc-list-item-graphic-fill-color(transparent);
43-
@include mdc-list-item-graphic-ink-color(text-icon-on-background);
44-
@include mdc-list-item-meta-ink-color(text-hint-on-background);
4540

4641
@include mdc-theme-dark {
4742
@include mdc-list-item-primary-text-ink-color(text-primary-on-dark);
@@ -59,6 +54,13 @@
5954
list-style-type: none;
6055
}
6156

57+
@at-root {
58+
@include mdc-list-item-secondary-text-ink-color(text-secondary-on-background);
59+
@include mdc-list-item-graphic-fill-color(transparent);
60+
@include mdc-list-item-graphic-ink-color(text-icon-on-background);
61+
@include mdc-list-item-meta-ink-color(text-hint-on-background);
62+
}
63+
6264
.mdc-list--dense {
6365
padding-top: 4px;
6466
padding-bottom: 4px;
@@ -215,8 +217,6 @@ a.mdc-list-item {
215217
// postcss-bem-linter: define list-group
216218

217219
.mdc-list-group {
218-
@include mdc-list-group-subheader-ink-color(text-primary-on-background);
219-
220220
@include mdc-theme-dark {
221221
@include mdc-list-group-subheader-ink-color(text-primary-on-dark);
222222
}
@@ -238,4 +238,8 @@ a.mdc-list-item {
238238
}
239239
}
240240

241+
@at-root {
242+
@include mdc-list-group-subheader-ink-color(text-primary-on-background);
243+
}
244+
241245
// postcss-bem-linter: end

0 commit comments

Comments
 (0)