-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment issues with mdc-checkbox with an mdc-list-item #1591
Comments
In the first example, wrapped, it's off by 8px on the top and 8px on the left. |
Incidentally, the Thanks for reporting this; I'm tracking it as a bug, as I think it might be worth examining whether we can make our existing styles more flexible rather than needing to add special cases for different types of components that are allowed in the start and end regions. |
I didn't think to try avatar. Thanks for the suggestion, it's much better than my position workaround. |
Per commit: 5dabcdf#diff-d5738923465a810c2132e773f88f3d23, I have updated the codepen here https://codepen.io/moog16/pen/wpZYOw?editors=1000. I do see an issue with alignment when the text is overflowing. I looked at spec and it doesn't have anything on the max-width, or if it should take the width of the longest row. I'm reaching out to the designer. |
Checked with designer - Text should ellipsis that overflows. It turns out that the ellipsis mixin was being used in mdc-list.scss, but not being applied. Fixing that bug. |
Bug
mdc-checkbox causes alignment issues when used with mdc-list-item
What MDC-Web Version are you using?
0.24.0
What browser(s) is this bug affecting?
Chrome, Firefox, Edge
What OS are you using?
Windows 10
What are the steps to reproduce the bug?
mdc-list-item__start-detail
andmdc-list-item__end-detail
or
mdc-list-item__start-detail
on one checkbox andmdc-list-item__end-detail
on the otherWhat is the expected behavior?
Checkboxes are properly aligned and shaped.
What is the actual behavior?
Checkboxes are misaligned in the start-detail and end-detail sections when wrapped with
<span class="mdc-list-item__start-detail">
or<span class="mdc-list-item__end-detail">
Checkboxes are misshaped and affect the alignment of the mdc-list-item
https://codepen.io/anon/pen/vWJWYL
The text was updated successfully, but these errors were encountered: