Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demos): Fix NPEs in drawer demos #1946

Merged
merged 4 commits into from
Jan 16, 2018
Merged

fix(demos): Fix NPEs in drawer demos #1946

merged 4 commits into from
Jan 16, 2018

Conversation

acdvorak
Copy link
Contributor

To repro:

  1. View the Temporary Drawer demo page in any browser
  2. Open the dev tools
  3. Open the drawer by clicking on the toolbar menu icon
  4. Click on a blank part of the drawer (NOT on a list item)

@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0b4b870). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1946   +/-   ##
=========================================
  Coverage          ?   99.43%           
=========================================
  Files             ?       84           
  Lines             ?     3721           
  Branches          ?      484           
=========================================
  Hits              ?     3700           
  Misses            ?       21           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4b870...b0323db. Read the comment docs.

@acdvorak acdvorak merged commit 2c92827 into master Jan 16, 2018
@acdvorak acdvorak deleted the fix/demos/npe branch January 16, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants