chore(tabs): removed .mdc-toolbar specific selectors #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 12, 2018 17:14
…mos to reflect this. BREAKING CHANGE: removal of .mdc-toolbar selector forces clients to customize tab-bars within toolbars that require a different ink color.
…mponents/material-components-web into chore/tabs/color-sass-mixins
…dated demos to reflect this." This reverts commit d98e5d8.
…mos to reflect this. BREAKING CHANGE: removal of .mdc-toolbar selector forces clients to customize tab-bars within toolbars that require a different ink color.
Codecov Report
@@ Coverage Diff @@
## master #1979 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 84 84
Lines 3717 3717
Branches 485 485
=======================================
Hits 3696 3696
Misses 21 21Continue to review full report at Codecov.
|
lynnmercier
approved these changes
Jan 22, 2018
docs/integrating-into-frameworks.md
Outdated
| @@ -71,7 +71,7 @@ In order to implement a component via a foundation, take the following steps: | |||
|
|
|||
| 1. Include the component's CSS on the page any way you wish | |||
| 2. Add an instance property to your component which will be set to the proper foundation class. | |||
| We'll calls this `mdcFoundation`. | |||
| We'll call this `mdcFoundation`. | |||
There was a problem hiding this comment.
This does not belong in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of: #1152
BREAKING CHANGE: removal of .mdc-toolbar selector forces clients to
customize tab-bars within toolbars that require a different ink color.