Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): Update menu icon to be anchor element #2372

Merged
merged 2 commits into from
Mar 9, 2018

Conversation

williamernest
Copy link
Contributor

Fixes: #2371

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM with one nit

@@ -141,6 +141,7 @@ <h1 class="mdc-typography--display1">Persistent Drawer</h1>
<button type="button" class="mdc-button mdc-button--stroked mdc-button--dense demo-toolbar-example-heading__rtl-toggle-button">Toggle RTL</button>
</main>

<script src="/assets/common.js" async></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think we'd been standardizing on putting common.js after mcw.js (I realize now I missed this in top-app-bar).

@williamernest williamernest merged commit 1065a74 into master Mar 9, 2018
@williamernest williamernest deleted the fix/drawer/nav-icon branch March 9, 2018 16:58
@englishextra
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants