Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base): Add mdc-emit-once utility mixin; deduplicate styles #2578

Merged
merged 7 commits into from
Apr 19, 2018

Conversation

kfranqueiro
Copy link
Contributor

This provides a single mechanism to avoid duplicating emitted CSS that is included by multiple components.

Note that our minification process already deduplicates styles, so this only has an effect on unminified code.

@kfranqueiro kfranqueiro force-pushed the feat/base-emit-once branch from c9f1dcb to 5f877e9 Compare April 17, 2018 14:56
@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #2578 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2578   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          98       98           
  Lines        4198     4198           
  Branches      533      533           
=======================================
  Hits         4143     4143           
  Misses         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976affd...de96066. Read the comment docs.

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I diffed the output of npm run build against master, and the duplicate rules have indeed been removed.

@kfranqueiro kfranqueiro merged commit 64a00b2 into master Apr 19, 2018
@kfranqueiro kfranqueiro deleted the feat/base-emit-once branch April 19, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants