Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox component is missing adapter APIs, leading to aria-checked not being updated #2579

Closed
kfranqueiro opened this issue Apr 17, 2018 · 1 comment
Closed

Checkbox component is missing adapter APIs, leading to aria-checked not being updated #2579

kfranqueiro opened this issue Apr 17, 2018 · 1 comment
Assignees
@kfranqueiro
Labels
accessibility backlog bug

Comments

@kfranqueiro
Copy link
Contributor

What MDC Web Version are you using?

0.34.1

What browser(s) is this bug affecting?

Any

What OS are you using?

Any

What are the steps to reproduce the bug?

What is the expected behavior?

aria-checked should be set to mixed on indeterminate JS checkboxes

What is the actual behavior?

aria-checked is never set

Any other information you believe would be useful?

Somehow we never implemented the setNativeControlAttr and removeNativeControlAttr adapter APIs in the checkbox component.
@kfranqueiro kfranqueiro self-assigned this Apr 17, 2018
@kfranqueiro
Copy link
Contributor Author

Traced to #2389, which added this functionality but didn't hook it up through the component, so it wasn't actually working.

@kfranqueiro kfranqueiro mentioned this issue Apr 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfranqueiro kfranqueiro

Labels
accessibility backlog bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kfranqueiro