Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(chips): Add nowrap to chip text #2671

Merged
merged 2 commits into from
Apr 30, 2018
Merged

Conversation

williamernest
Copy link
Contributor

fixes: #2667
Chips with spaces in the text are wrapping when the exit animation is occurring, causing the chip to increase in height.

@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #2671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2671   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          98       98           
  Lines        4230     4230           
  Branches      537      537           
=======================================
  Hits         4166     4166           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9556a...8b1f7c0. Read the comment docs.

Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@williamernest williamernest merged commit 7abb3a2 into master Apr 30, 2018
@williamernest williamernest deleted the fix/chips/height-during-exit branch April 30, 2018 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing chip changes other chips' height when chip text has spaces
3 participants