fix(chips): Add an event typedef for chip interaction events #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2965 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 101 101
Lines 4368 4368
Branches 564 564
======================================
Hits 4294 4294
Misses 74 74
Continue to review full report at Codecov.
|
bonniezhou
suggested changes
Jun 20, 2018
| @@ -15,7 +15,8 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| /* eslint no-unused-vars: [2, {"args": "none"}] */ | |||
| /* eslint-disable no-unused-vars */ | |||
| import {MDCChipInteractionEventType} from '../chip/foundation'; | |||
There was a problem hiding this comment.
I think we want to keep the no-unused-vars: [2, {"args": "none"}] rule for the rest of the file, so you can do something like this:
// eslint-disable-next-line no-unused-vars
import {MDCChipInteractionEventType} from '../chip/foundation';
/* eslint no-unused-vars: [2, {"args": "none"}] */
...
| @@ -17,7 +17,8 @@ | |||
|
|
|||
| import MDCFoundation from '@material/base/foundation'; | |||
| import MDCChipSetAdapter from './adapter'; | |||
| import MDCChipFoundation from '../chip/foundation'; | |||
| /* eslint-disable no-unused-vars */ | |||
There was a problem hiding this comment.
Same here, use // eslint-disable-next-line no-unused-vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.