fix(checkbox): remove native control from getters/setters of foundation #3408
Conversation
|
All 353 screenshot tests passed for commit e3c7c9d vs. |
|
All 353 screenshot tests passed for commit ecd0520 vs. |
Codecov Report
@@ Coverage Diff @@
## master #3408 +/- ##
========================================
Coverage ? 98.3%
========================================
Files ? 119
Lines ? 5010
Branches ? 613
========================================
Hits ? 4925
Misses ? 85
Partials ? 0
Continue to review full report at Codecov.
|
packages/mdc-checkbox/foundation.js
Outdated
| @@ -292,8 +260,8 @@ class MDCCheckboxFoundation extends MDCFoundation { | |||
| } | |||
|
|
|||
| updateAriaChecked_() { | |||
| // Ensure aria-checked is set to mixed if checkbox is in indeterminate state. | |||
| if (this.isIndeterminate()) { | |||
| // Ensure aria-checked is set to if checkbox is in indeterminate state. | |||
There was a problem hiding this comment.
You accidentally deleted mixed somehow
|
@kfranqueiro I don't want to do the changes until this PR is merged in, since it is highly dependent on this PR. |
|
All 353 screenshot tests passed for commit b99202f vs. |
|
All 349 screenshot tests passed for commit ad97f84 vs. |
|
All 349 screenshot tests passed for commit 1ee6735 vs. |
packages/mdc-checkbox/index.js
Outdated
| * @private | ||
| */ | ||
| isIndeterminate_() { | ||
| return this.nativeCb_.indeterminate; |
There was a problem hiding this comment.
Can we move these to the get methods and then update the adapter to use the public get ? Seems like we don't really need the private function.
|
All 349 screenshot tests passed for commit 0f7fecc vs. |
|
All 349 screenshot tests passed for commit 4ac34a7 vs. |
refs #3396
Will move the ObjectPropertyDescriptor override into the component in a follow up PR