fix(select): Remove style customization for native select > option #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
commented
Nov 15, 2018
packages/mdc-select/_mixins.scss
Outdated
| @@ -272,7 +272,7 @@ | |||
| } | |||
|
|
|||
| > option { | |||
| @include mdc-theme-prop(background-color, surface); | |||
| @include mdc-theme-prop(background-color, surface, $edgeOptOut: true); | |||
There was a problem hiding this comment.
@williamernest Do you know why we're applying styles to native elements here? select / option native elements doesn't allow style customization in most of the browser as far as I know.
|
In browsers that do allow customizations our native select needs to use a
different background color.
…On Thu, Nov 15, 2018, 8:42 AM Abhinay Omkar ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/mdc-select/_mixins.scss
<#4089 (comment)>
:
> @@ -272,7 +272,7 @@
}
> option {
- @include mdc-theme-prop(background-color, surface);
+ @include mdc-theme-prop(background-color, surface, $edgeOptOut: true);
@williamernest <https://github.com/williamernest> Do you know why we're
applying styles to native elements here? select / option native elements
doesn't allow style customization in most of the browser as far as I know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4089 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ag65XBuNPiud3UpcYB2ZnR-b9LADe61Jks5uvZmNgaJpZM4YgSJf>
.
|
|
All 663 screenshot tests passed for commit 8b30085 vs. |
abhiomkar
changed the title
|
All 663 screenshot tests passed for commit 7e0d3b0 vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge browser allows customizing only the background color of
<option>element but not the text color.example on jsfiddle.
This fix removes any styles applied to native
<option>element.Fixes #4088