Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR for MDC Tab: Remove hardcoded opacity and allow developers to specify #4487

Closed
bwobrien opened this issue Mar 8, 2019 · 1 comment
Closed

FR for MDC Tab: Remove hardcoded opacity and allow developers to specify #4487

bwobrien opened this issue Mar 8, 2019 · 1 comment
Milestone
April 22 Release

Comments

@bwobrien
Copy link
Contributor

bwobrien commented Mar 8, 2019

The opacity of the Tab's text label and icon is hardcoded with no way to overwrite it via official mixins (https://github.com/material-components/material-components-web/blob/master/packages/mdc-tab/mdc-tab.scss#L90,L101).

Rather than add a mixin for opacity specifically, this request is to remove the hardcoded opacity and simply allow developers to specify opacity by passing an rgba value to color-related Sass mixins (e.g. mdc-tab-text-label-color)
@kfranqueiro kfranqueiro added this to the April release milestone Mar 11, 2019
@abhiomkar
Copy link
Collaborator

Seems like this was fixed in #4675 Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April 22 Release
Development

No branches or pull requests
3 participants
@abhiomkar @bwobrien @kfranqueiro