Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox ripple mixin doesn't allow customization #4597

Closed
moog16 opened this issue Apr 12, 2019 · 3 comments
Closed

Checkbox ripple mixin doesn't allow customization #4597

moog16 opened this issue Apr 12, 2019 · 3 comments

Comments

@moog16
Copy link
Contributor

moog16 commented Apr 12, 2019

Expected use of @mixin mdc-ripple-radius-unbounded with the checkbox is:

.mdc-checkbox {
  @include mdc-ripple-radius-unbounded(50%);
}

This however doesn't work, since the JS checkbox progamatically creates CSS vars and puts them on the element. This overrides the sass mixin, which stops this from working.

Example:
https://glitch.com/edit/#!/fishy-course?path=index.scss:5:7

@abhiomkar
Copy link
Collaborator

This might be related to #4530 (as per Density work).

@abhiomkar abhiomkar added this-Q and removed backlog labels Apr 19, 2019
@moog16
Copy link
Contributor Author

moog16 commented Apr 19, 2019

Not sure if the change allows us to break the ratio between size of checkbox and radius of unbounded ripple. It looks like we can change the size of the checkbox, but what if we want to make the ratio of the ripple size larger/smaller?

@abhiomkar
Copy link
Collaborator

PR #4697 fixes this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants