Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-indicator): Remove child selector #4676

Merged
merged 4 commits into from
May 3, 2019
Merged

Conversation

patrickrodee
Copy link
Contributor

No description provided.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

codecov-io commented May 3, 2019

Codecov Report

Merging #4676 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4676   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files         129      129           
  Lines        6294     6294           
  Branches      821      821           
=======================================
  Hits         6229     6229           
  Misses         64       64           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252009f...0ca1351. Read the comment docs.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels May 3, 2019
@moog16
Copy link
Contributor

moog16 commented May 3, 2019

@patrickrodee did you do this change on a non-google account? If it was - we can override the cla.

@patrickrodee
Copy link
Contributor Author

Nope, I've done it all on my corp machine. Let's override.

@moog16 moog16 added cla: yes and removed cla: no labels May 3, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

30 screenshots changed from master on commit 0ca1351:

Details

30 Changed:

@patrickrodee patrickrodee merged commit edbe0ba into master May 3, 2019
@patrickrodee patrickrodee deleted the simplifytabindicator branch May 3, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants