Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): Add setSelectedFromChipset method #4872

Merged
merged 4 commits into from
Jul 3, 2019

Conversation

patrickrodee
Copy link
Contributor

No description provided.

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Nit comment: setSelectedFromChipset --> setSelectedFromChipSet (cap the S in ChipSet).

@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

Merging #4872 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #4872      +/-   ##
==========================================
+ Coverage    98.88%   98.9%   +0.01%     
==========================================
  Files          119     119              
  Lines         5823    5830       +7     
  Branches       778     779       +1     
==========================================
+ Hits          5758    5766       +8     
+ Misses          64      63       -1     
  Partials         1       1
Impacted Files Coverage Δ
packages/mdc-chips/chip/component.ts 99.09% <100%> (+0.01%) ⬆️
packages/mdc-chips/chip-set/component.ts 97.33% <100%> (ø) ⬆️
packages/mdc-chips/chip/foundation.ts 100% <100%> (ø) ⬆️
packages/mdc-dialog/foundation.ts 99.34% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07078bb...d03e55d. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 29ac2c2 vs. develop! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 0e15717 vs. develop! 💯🎉

@patrickrodee
Copy link
Contributor Author

Update from revivew

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit dee380a vs. develop! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit d03e55d vs. develop! 💯🎉

@patrickrodee patrickrodee merged commit 283bd55 into develop Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixChipLoopLogic branch July 3, 2019 19:51
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants