Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ripple): Add support for ripple target to mixins. #4880

Merged
merged 16 commits into from
Jul 11, 2019
Merged

feat(ripple): Add support for ripple target to mixins. #4880

merged 16 commits into from
Jul 11, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Jul 8, 2019 •
edited
Loading

This is to support moving the ripple target to an inner element for components with increased touch target (button, chips, etc.)

@codecov-io
Copy link

codecov-io commented Jul 9, 2019 •
edited
Loading

Codecov Report

Merging #4880 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #4880   +/-   ##
=======================================
  Coverage     98.9%   98.9%           
=======================================
  Files          119     119           
  Lines         5830    5830           
  Branches       779     779           
=======================================
  Hits          5766    5766           
  Misses          63      63           
  Partials         1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2cd75...306f0c1. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 8f80edd vs. develop! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit cd9a089 vs. develop! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 9021755 vs. develop! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit cfff73e vs. develop! 💯🎉

@joyzhong joyzhong requested a review from abhiomkar July 9, 2019 18:09
@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 80aec16 vs. develop! 💯🎉

abhiomkar
abhiomkar requested changes Jul 10, 2019
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
@joyzhong joyzhong requested a review from abhiomkar July 10, 2019 18:51
@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 8197f79 vs. develop! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 2c9a37a vs. develop! 💯🎉

abhiomkar
abhiomkar requested changes Jul 10, 2019
View reviewed changes
packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
@joyzhong joyzhong requested a review from abhiomkar July 10, 2019 21:42
@joyzhong joyzhong added the wip label Jul 10, 2019
@joyzhong joyzhong removed the wip label Jul 10, 2019
@joyzhong joyzhong added the wip label Jul 10, 2019
@joyzhong joyzhong removed the wip label Jul 10, 2019
@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit b749087 vs. develop! 💯🎉

abhiomkar
abhiomkar approved these changes Jul 11, 2019
View reviewed changes
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

packages/mdc-ripple/_mixins.scss
"&:not(.mdc-ripple-upgraded):focus::before, &:not(.mdc-ripple-upgraded):focus-within::before",
"&:not(.mdc-ripple-upgraded):focus::before"
);
@if $has-nested-focusable-element {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks lot better! 🎉

Thanks for making this more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great suggestion!

packages/mdc-ripple/_mixins.scss Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 699 screenshot tests passed for commit 306f0c1 vs. develop! 💯🎉

@joyzhong joyzhong merged commit 08dbe69 into develop Jul 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/ripple_target branch July 11, 2019 01:50
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
Merged
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

Assignees

@abhiomkar abhiomkar

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyzhong @codecov-io @mdc-web-bot @abhiomkar @googlebot