Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(button): Add ripple target as an inner element. #4890

Merged
merged 38 commits into from
Jul 12, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Jul 10, 2019

BREAKING CHANGE: This changes the structure of the button element by moving the ripple from the outer element to an inner mdc-button__ripple element.

OLD

<button class="mdc-button">
  <span class="mdc-button__label">Hello World</span>
</button>

NEW

<button class="mdc-button">
  <div class="mdc-button__ripple"></div>
  <span class="mdc-button__label">Hello World</span>
</button>

@joyzhong joyzhong added the wip label Jul 11, 2019
Copy link
Contributor Author

@joyzhong joyzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I updated screenshots due to the button label text now overflowing as a result of removing overflow: hidden from button. Filed #4894 to fix the button label bug.

@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@08dbe69). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #4890   +/-   ##
=========================================
  Coverage           ?   98.9%           
=========================================
  Files              ?     119           
  Lines              ?    5830           
  Branches           ?     779           
=========================================
  Hits               ?    5766           
  Misses             ?      63           
  Partials           ?       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08dbe69...597f6b3. Read the comment docs.

…ipple does not cover the full outlined button radius.
@joyzhong joyzhong added the wip label Jul 12, 2019
@joyzhong joyzhong removed the wip label Jul 12, 2019
@joyzhong
Copy link
Contributor Author

Ready for review.

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joyzhong joyzhong closed this Jul 12, 2019
@joyzhong joyzhong reopened this Jul 12, 2019
@joyzhong joyzhong merged commit dffefe6 into develop Jul 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor/button_ripple branch July 12, 2019 20:16
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants