-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(button): Add ripple target as an inner element. #4890
Conversation
This reverts commit da5a79e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I updated screenshots due to the button label text now overflowing as a result of removing overflow: hidden
from button. Filed #4894 to fix the button label bug.
🤖 Beep boop! Screenshot test report 🚦14 screenshots changed from |
Codecov Report
@@ Coverage Diff @@
## develop #4890 +/- ##
=========================================
Coverage ? 98.9%
=========================================
Files ? 119
Lines ? 5830
Branches ? 779
=========================================
Hits ? 5766
Misses ? 63
Partials ? 1 Continue to review full report at Codecov.
|
🤖 Beep boop! Screenshot test report 🚦14 screenshots changed from |
…ipple does not cover the full outlined button radius.
🤖 Beep boop! Screenshot test report 🚦29 screenshots changed from |
🤖 Beep boop! Screenshot test report 🚦14 screenshots changed from |
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
🤖 Beep boop! Screenshot test report 🚦14 screenshots changed from |
BREAKING CHANGE: This changes the structure of the button element by moving the ripple from the outer element to an inner
mdc-button__ripple
element.OLD
NEW