feat(dialog): Add dialog mixin for dialogs with increased touch target buttons. #5024
Conversation
|
All 711 screenshot tests passed for commit 88a9b07 vs. |
|
All 711 screenshot tests passed for commit e85ca3c vs. |
|
All 711 screenshot tests passed for commit ccbaffe vs. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
…tons with increased touch target, which have an increased vertical margin.
joyzhong
force-pushed
the
feat/dialog_touchtarget
branch
from
f351193 to
bc9b11e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5024 +/- ##
==========================================
Coverage ? 98.68%
==========================================
Files ? 122
Lines ? 6008
Branches ? 792
==========================================
Hits ? 5929
Misses ? 78
Partials ? 1
Continue to review full report at Codecov.
|
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
All 708 screenshot tests passed for commit bc9b11e vs. |
|
All 708 screenshot tests passed for commit 01cb71e vs. |
|
All 708 screenshot tests passed for commit 0eb1166 vs. |
Compensate for buttons with increased touch target, which have an increased vertical margin.