Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form-field): Fix radio RTL alignment bug. #5064

Merged
merged 11 commits into from
Sep 20, 2019
Merged

fix(form-field): Fix radio RTL alignment bug. #5064

merged 11 commits into from
Sep 20, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Sep 10, 2019 •
edited
Loading

Also add form-field radio screenshot tests.
Fixes b/140750923 internally.

@joyzhong joyzhong requested a review from abhiomkar September 10, 2019 20:48
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

6 screenshots changed from master on commit c0d96b9:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

6 screenshots changed from master on commit 6570700:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

6 screenshots changed from master on commit 3613636:

Details

@joyzhong joyzhong merged commit ef99808 into master Sep 20, 2019
@joyzhong joyzhong deleted the fix/radio_rtl branch September 20, 2019 18:38
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
Merged
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

Assignees

@abhiomkar abhiomkar

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyzhong @mdc-web-bot @abhiomkar @googlebot