feat(tab-bar): Add a mixin to set scroller animation #5172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @cletusw |
abhiomkar
force-pushed
the
feat/tabs_anim_mixin
branch
from
d878aff to
7bd1d93
Compare
abhiomkar
force-pushed
the
feat/tabs_anim_mixin
branch
from
7bd1d93 to
8292ca9
Compare
|
All 719 screenshot tests passed for commit d878aff vs. |
Codecov Report
@@ Coverage Diff @@
## develop #5172 +/- ##
========================================
Coverage 98.64% 98.64%
========================================
Files 122 122
Lines 5988 5988
Branches 770 770
========================================
Hits 5907 5907
Misses 80 80
Partials 1 1Continue to review full report at Codecov.
|
|
All 719 screenshot tests passed for commit 7bd1d93 vs. |
|
All 719 screenshot tests passed for commit 8292ca9 vs. |
joyzhong
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Tab Scroller is a helper component that clients may not have access to uses this new mixin (
mdc-tab-bar-tab-scroller-transition()callstab-scroller-transition()) that sets styles to child component.