feat(text-field): Add disabled state color mixins #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Redundant mixins `mdc-text-field-textarea-fill-color`, `mdc-text-field-textarea-stroke-color`, `mdc-text-field-fullwidth-bottom-line-color` removed. Instead, use `mdc-text-field-fill-color`, `mdc-text-field-outline-color`, and `mdc-text-field-bottom-line-color` respectively to achieve the same effect.
|
🤖 Beep boop! Screenshot test report 🚦36 screenshots changed from |
abhiomkar
requested changes
Nov 6, 2019
test/screenshot/spec/mdc-textfield/classes/disabled-character-counter.html
Show resolved
Hide resolved
|
🤖 Beep boop! Screenshot test report 🚦9 screenshots changed from |
|
🤖 Beep boop! Screenshot test report 🚦9 screenshots changed from |
abhiomkar
approved these changes
Nov 7, 2019
| @@ -1399,6 +1399,14 @@ | |||
| "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-textfield/classes/baseline.html.windows_ie_11.png" | |||
| } | |||
| }, | |||
| "spec/mdc-textfield/classes/disabled-character-counter.html": { | |||
There was a problem hiding this comment.
Let's delete this file too since this is already covered in below screenshot.
There was a problem hiding this comment.
It's a baseline test that was missing before and failed to catch that the character counter color was previously incorrect when disabled. It's not one of the mixin tests
|
🤖 Beep boop! Screenshot test report 🚦9 screenshots changed from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Redundant mixins
mdc-text-field-textarea-fill-color,mdc-text-field-textarea-stroke-color,mdc-text-field-fullwidth-bottom-line-colorremoved. Instead, usemdc-text-field-fill-color,mdc-text-field-outline-color, andmdc-text-field-bottom-line-colorrespectively to achieve the same effect.