This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(chips): Consolidate interaction event handlers #5251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All 731 screenshot tests passed for commit 3f7af7f vs. |
Codecov Report
@@ Coverage Diff @@
## master #5251 +/- ##
=========================================
Coverage ? 98.63%
=========================================
Files ? 122
Lines ? 6002
Branches ? 772
=========================================
Hits ? 5920
Misses ? 81
Partials ? 1
Continue to review full report at Codecov.
|
All 731 screenshot tests passed for commit d7225b7 vs. |
joyzhong
approved these changes
Nov 18, 2019
abhiomkar
added a commit
that referenced
this pull request
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate interaction event handlers into discrete root-level handlers:
handleClick
andhandleKeydown
.BREAKING CHANGE: the
handleInteraction
andhandleTrailingIconInteraction
handlers have been removed from theMDCChipFoundation
. ThehandleClick
handler has been added to theMDCChipFoundation