fix(fab): Adjust fab line-height #5254
Conversation
| @@ -333,6 +333,8 @@ $mdc-fab-icon-enter-duration_: 180ms; | |||
| width: auto; | |||
| max-width: 100%; | |||
| height: $mdc-fab-extended-height; | |||
| /* @alternate */ | |||
There was a problem hiding this comment.
Can you add a code comment about why we do this?
There was a problem hiding this comment.
It is mostly an issue with the CSS compilation because there are multiple identical, non-alternate declarations in the same ruleset. line-height is being set twice within .mdc-fab--extended, once in mdc-typography(button, $query: $query) and then again here. Similar code is done within button/mixins.scss.
Added comment!
There was a problem hiding this comment.
Sorry, I meant comment for line-height: inherit :)
There was a problem hiding this comment.
No worries, updated the comment 👍
| @@ -333,6 +333,8 @@ $mdc-fab-icon-enter-duration_: 180ms; | |||
| width: auto; | |||
| max-width: 100%; | |||
| height: $mdc-fab-extended-height; | |||
| /* @alternate */ | |||
There was a problem hiding this comment.
Sorry, I meant comment for line-height: inherit :)
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from |
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from |
No description provided.