Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(chips): Do not throw error if chip set becomes empty #5290

Merged
merged 3 commits into from
Dec 2, 2019
Merged

fix(chips): Do not throw error if chip set becomes empty #5290

merged 3 commits into from
Dec 2, 2019

Conversation

bonniezhou
Copy link
Contributor

Fixes #5275

@codecov-io
Copy link

codecov-io commented Nov 29, 2019 •
edited
Loading

Codecov Report

Merging #5290 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5290      +/-   ##
==========================================
+ Coverage   98.63%   98.63%   +<.01%     
==========================================
  Files         122      122              
  Lines        5991     5993       +2     
  Branches      768      769       +1     
==========================================
+ Hits         5909     5911       +2     
  Misses         81       81              
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-chips/chip-set/foundation.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8bc4a2...0215408. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit f7c0794 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 0215408 vs. master! 💯🎉

@bonniezhou bonniezhou merged commit f978109 into master Dec 2, 2019
@bonniezhou bonniezhou deleted the fix/chips-empty-set branch December 2, 2019 17:03
@abhiomkar abhiomkar restored the fix/chips-empty-set branch December 3, 2019 21:27
@abhiomkar abhiomkar deleted the fix/chips-empty-set branch December 3, 2019 21:27
abhiomkar added a commit that referenced this pull request Dec 3, 2019
@abhiomkar
Revert "fix(chips): Do not throw error if chip set becomes empty (#5290…
719e03d 
…)"

This reverts commit f978109.
@abhiomkar abhiomkar mentioned this pull request Dec 3, 2019
Merged
This was referenced Feb 13, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@adrianschmidt adrianschmidt mentioned this pull request Dec 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@patrickrodee patrickrodee patrickrodee approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: i.chips_[t] is undefined after removing all input chips from page
5 participants
@bonniezhou @codecov-io @mdc-web-bot @patrickrodee @googlebot