This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(elevation): Restructure overlay color mixin #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickrodee
changed the title
|
All 731 screenshot tests passed for commit 3b9a889 vs. |
joyzhong
approved these changes
Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixin previously always included the
.mdc-elevation-overlayclass, making it impossible to override the colors without a wrapping element. Now, a custom class can be applied to the overlay element and the colors can be overridden with no additional specificity or DOM changes.