This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(textfield): change root element to <label> #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncLiz
changed the title
|
All 584 screenshot tests passed for commit b3ab9e1 vs. |
PiperOrigin-RevId: 288775969
asyncLiz
force-pushed
the
cl_288775969
branch
from
b3ab9e1 to
b337f99
Compare
|
All 263 screenshot tests passed for commit b337f99 vs. |
|
All 263 screenshot tests passed for commit 22a4a9b vs. |
allan-chen
approved these changes
Jan 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: text field's root element has changed from a
<div>to a<label>. Existing labels should be changed to<span>with an ID.<input>should usearia-labelledbyand reference span's IDProject import generated by Copybara.