Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(auto-init): Fixed issue with multiple default exports #5464

Merged
merged 1 commit into from
Jan 15, 2020
Merged

fix(auto-init): Fixed issue with multiple default exports #5464

merged 1 commit into from
Jan 15, 2020

Conversation

abhiomkar
Copy link
Collaborator

mdc-auto-init/index.d.ts:

Before (ref):

export default mdcAutoInit;
export default mdcAutoInit;

After:

export default mdcAutoInit;
export { mdcAutoInit };

Closes #5158

@abhiomkar abhiomkar requested a review from asyncLiz January 14, 2020 17:54
asyncLiz
asyncLiz approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhiomkar abhiomkar force-pushed the fix/autoinit_export branch from de7a94d to f6d2964 Compare January 14, 2020 21:56
@mdc-web-bot
Copy link
Collaborator

All 305 screenshot tests passed for commit f6d2964 vs. master! 💯🎉

@abhiomkar abhiomkar merged commit 8ddd5c6 into master Jan 15, 2020
@abhiomkar abhiomkar deleted the fix/autoinit_export branch January 15, 2020 01:36
@allan-chen allan-chen mentioned this pull request Feb 5, 2020
Closed
This was referenced Feb 13, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@adrianschmidt adrianschmidt mentioned this pull request Dec 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asyncLiz asyncLiz asyncLiz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mdc-auto-init] npm index.d.ts has multiple default exports
4 participants
@abhiomkar @mdc-web-bot @asyncLiz @googlebot