This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat: Add index stylesheets to each MDC Web package #5539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
changed the title
abhiomkar
commented
Jan 29, 2020
|
All 191 screenshot tests passed for commit d7b06f1 vs. |
|
@nex3 mdc-image-list & mdc-layout-grid are missing in this PR. This is expected since these 2 packages are not synced internally. Can we run the migrator on these 2 packages in a separate PR? We don't need to import these. Thanks! |
|
Done: #5546 |
PiperOrigin-RevId: 292018225
abhiomkar
force-pushed
the
cl_292018225
branch
from
d7b06f1 to
f9f74ca
Compare
|
All 191 screenshot tests passed for commit f9f74ca vs. |
|
LGTM based on cl/292403730 review |
joyzhong
approved these changes
Jan 30, 2020
jathak
added a commit
to jathak/material-components-web
that referenced
this pull request
Apr 30, 2020
PR material-components#5539 improperly prefixed some members in components that previously had a mixin with the same name as their prefix. This caused issues downstream when two components have members with the same name (e.g. `mdc-core-styles`). This fixes those import-only files to use the correct prefix for all members.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project import generated by Copybara.
Author: @nex3