-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Add index stylesheets to mdc-image-list and mdc-layout-grid. #5546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the build is failing for mdc-image-list.
loader/src??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--4-3!./test/screenshot/spec/mdc-image-list/fixture.scss)
Module build failed (from ./node_modules/sass-loader/lib/loader.js):
@forward "@material/feature-targeting" as mdc-feature-*;
^
Can't find stylesheet to import.
╷
1 │ @forward "@material/feature-targeting" as mdc-feature-*;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
packages/mdc-image-list/_mixins.import.scss 1:1 @import
stdin 23:9 root stylesheet
Can you replace @import
with @use
in test/screenshot/spec/mdc-image-list/fixture.scss
file to see if that fixes the issue?
Looks like that did it 🤷♀️. |
@abhiomkar I may have stumbled on similar issue upgrading Angular MDC to v5.0-canary branch. If a component package folder contains Works successfully with Fails to compile using Edit: Since |
Does anyone have a reproduction that just uses the command-line Sass compiler, so I can debug into it and see what's going wrong here? |
This* surely looks like I'm able to reproduce only with sass-loader (Webpack Sass plugin): |
Created bug with sass-loader. |
Adds indexes to GitHub-only stylesheets that aren't covered by #5539.