Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): .d.ts file generated with syntax error #5577

Merged
merged 1 commit into from
Feb 7, 2020
Merged

fix(chips): .d.ts file generated with syntax error #5577

merged 1 commit into from
Feb 7, 2020

Conversation

crisbeto
Copy link
Collaborator

@crisbeto crisbeto commented Feb 7, 2020

Due to the way a comment was formatted in the chip foundation the .d.ts bundler ended up generating a file with a syntax error.

For reference, here's what was being generated:
●_mdc chips d ts_-material-components-web-_Visua_2020-02-07_19-24-23

@crisbeto
fix(chips): .d.ts file generated with syntax error
d154836 
Due to the way a comment was formatted in the chip foundation the .d.ts bundler ended up generating a file with a syntax error.
@crisbeto crisbeto requested a review from abhiomkar February 7, 2020 18:28
@abhiomkar abhiomkar mentioned this pull request Feb 7, 2020
Open
@abhiomkar abhiomkar merged commit 98f7faa into material-components:master Feb 7, 2020
copybara-service bot pushed a commit that referenced this pull request Feb 7, 2020
@abhiomkar @copybara-github
docs: Update getting started doc to use Sass module syntax
e8dc877 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293466751
@copybara-service copybara-service bot mentioned this pull request Feb 7, 2020
Merged
copybara-service bot pushed a commit that referenced this pull request Feb 7, 2020
@abhiomkar @copybara-github
docs: Update theming doc to use Sass module syntax.
4fff3c5 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293591664
@copybara-service copybara-service bot mentioned this pull request Feb 7, 2020
Merged
copybara-service bot pushed a commit that referenced this pull request Feb 7, 2020
@abhiomkar @copybara-github
docs: Update theming doc to use Sass module syntax.
ee8c7f5 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293591664
abhiomkar added a commit that referenced this pull request Feb 7, 2020
@copybara-service @abhiomkar
docs: Update getting started doc to use Sass module syntax (#5568)
b3df023 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293466751

Co-authored-by: Abhinay Omkar <abhiomkar@gmail.com>
abhiomkar added a commit that referenced this pull request Feb 7, 2020
@copybara-service @abhiomkar
docs: Update theming doc to use Sass module syntax. (#5582)
91aa2d6 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293591664

Co-authored-by: Abhinay Omkar <abhiomkar@gmail.com>
crisbeto added a commit to crisbeto/material2 that referenced this pull request Feb 7, 2020
@crisbeto
build: update to latest MDC canary
a7fb788 
For a while we were stuck on an older Canary version, because MDC was shipping an invalid .d.ts file to npm (see material-components/material-components-web#5577). These changes bump us to the latest one to hopefully resolve the master CI checks.
@crisbeto crisbeto mentioned this pull request Feb 7, 2020
Merged
copybara-service bot pushed a commit that referenced this pull request Feb 7, 2020
@abhiomkar @copybara-github
docs: Update few other places to remove mdc-* prefix from mixin name
8f9a831 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293869501
@copybara-service copybara-service bot mentioned this pull request Feb 7, 2020
Merged
copybara-service bot pushed a commit that referenced this pull request Feb 7, 2020
@abhiomkar @copybara-github
docs: Update few other places to remove mdc-* prefix from mixin name
60d8b53 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293869501
crisbeto added a commit to crisbeto/material2 that referenced this pull request Feb 7, 2020
@crisbeto
build: update to latest MDC canary
7322c7b 
For a while we were stuck on an older Canary version, because MDC was shipping an invalid .d.ts file to npm (see material-components/material-components-web#5577). These changes bump us to the latest one to hopefully resolve the master CI checks.
abhiomkar added a commit that referenced this pull request Feb 7, 2020
@copybara-service @abhiomkar
docs: Update few other places to remove mdc-* prefix from mixin… (#5584)
0b9e575 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5577 from crisbeto:mdc-chips-d-ts-error d154836
PiperOrigin-RevId: 293869501

Co-authored-by: Abhinay Omkar <abhiomkar@gmail.com>
mmalerba pushed a commit to angular/components that referenced this pull request Feb 7, 2020
@crisbeto
build: update to latest MDC canary (#18436)
474c838 
For a while we were stuck on an older Canary version, because MDC was shipping an invalid .d.ts file to npm (see material-components/material-components-web#5577). These changes bump us to the latest one to hopefully resolve the master CI checks.
abhiomkar added a commit that referenced this pull request Feb 7, 2020
@abhiomkar
Merge pull request #5577 from crisbeto:mdc-chips-d-ts-error
91d9d5a 
PiperOrigin-RevId: 293899769
This was referenced Feb 13, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@adrianschmidt adrianschmidt mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

Assignees
No one assigned
Labels
cla: yes Ready for Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @abhiomkar @googlebot