Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segmented-button): Add new package for segmented button #6073

Merged
merged 6 commits into from
Jun 26, 2020
Merged

feat(segmented-button): Add new package for segmented button #6073

merged 6 commits into from
Jun 26, 2020

Conversation

gschrag
Copy link
Collaborator

@gschrag gschrag commented Jun 15, 2020

create segmented button component to let user manipulate toggle values of a group of related buttons

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mdc-segmented-button.scss => styles.scss

go/material-sass-style#css-style-modules (See shared doc if you're not able to access).

@abhiomkar
Copy link
Collaborator

Can you remove "Closes PR number" line from PR description. GitHub will automatically closes issue when this PR is merged which is not what we wanted.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add following Copyright lines to all Sass files instead of empty files.

//
// Copyright 2020 Google Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
//

// TODO: Add styles.

@gschrag
Copy link
Collaborator Author

gschrag commented Jun 23, 2020

@abhiomkar do you know why adding the package.json "description" field in commit e76a6ad broke the dependency test?

@abhiomkar
Copy link
Collaborator

Test failure is expected. You'll need to edit CSS bundle factory to include new segmented styles. https://github.com/material-components/material-components-web/blob/master/scripts/webpack/css-bundle-factory.js

'mdc.segmented-button': getAbsolutePath('/packages/mdc-segmented-button/styles.scss'),

@gschrag
Copy link
Collaborator Author

gschrag commented Jun 24, 2020

I've noticed that all other mdc components have a '.scss' (e.g. 'mdc-button.scss') instead of a 'styles.scss'. I've also noticed that this style decision and others discussed in go/material-sass-style don't match how the sass files are actually implemented by mdc components. Is go/material-sass-style meant for a different repository?

gschrag added 6 commits June 26, 2020 15:31
create segmented button component to let user manipulate toggle values of a group of related buttons

closes #6069
add directory field to package.json and rename scss file
include license in all source files
include new segmented styles and add newlines to files
use segmented-button sass in material-components-web
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abhiomkar abhiomkar changed the title feat: create new component segmented button feat(segmented-button): Add new package for segmented button Jun 26, 2020
@abhiomkar abhiomkar merged commit d561860 into material-components:master Jun 26, 2020
@gschrag gschrag mentioned this pull request Jul 14, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants