-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(segmented-button): Add new package for segmented button #6073
feat(segmented-button): Add new package for segmented button #6073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: mdc-segmented-button.scss
=> styles.scss
go/material-sass-style#css-style-modules (See shared doc if you're not able to access).
Can you remove "Closes PR number" line from PR description. GitHub will automatically closes issue when this PR is merged which is not what we wanted. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add following Copyright lines to all Sass files instead of empty files.
//
// Copyright 2020 Google Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
//
// TODO: Add styles.
@abhiomkar do you know why adding the package.json "description" field in commit e76a6ad broke the dependency test? |
Test failure is expected. You'll need to edit CSS bundle factory to include new segmented styles. https://github.com/material-components/material-components-web/blob/master/scripts/webpack/css-bundle-factory.js 'mdc.segmented-button': getAbsolutePath('/packages/mdc-segmented-button/styles.scss'), |
I've noticed that all other mdc components have a '.scss' (e.g. 'mdc-button.scss') instead of a 'styles.scss'. I've also noticed that this style decision and others discussed in go/material-sass-style don't match how the sass files are actually implemented by mdc components. Is go/material-sass-style meant for a different repository? |
create segmented button component to let user manipulate toggle values of a group of related buttons closes #6069
add directory field to package.json and rename scss file
include license in all source files
include new segmented styles and add newlines to files
add dependency to fix tests
use segmented-button sass in material-components-web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
create segmented button component to let user manipulate toggle values of a group of related buttons