feat(segmented-button): Add initial Sass styles #6141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschrag
commented
Jun 25, 2020
abhiomkar
requested changes
Jun 30, 2020
|
I didn't see your comments before making commit #7376282. I'll make the requested changes and commit them soon. |
abhiomkar
requested changes
Jul 6, 2020
abhiomkar
reviewed
Jul 6, 2020
|
I've left it in draft because I keep making major changes and because it can't yet handle the wrapping 'touch' divs or ripple. But it's getting more stable and I can add what's missing in later PRs. |
abhiomkar
requested changes
Jul 7, 2020
packages/mdc-segmented-button/segmented-button/_segmented-button-theme.scss
Outdated
Show resolved
Hide resolved
abhiomkar
reviewed
Jul 13, 2020
|
Ready for re-review (I'm not sure why the site-generator-test failed). |
|
I'm almost ready to submit the follow-up PR with ripple and touch support. |
abhiomkar
requested changes
Jul 20, 2020
abhiomkar
requested changes
Jul 21, 2020
packages/mdc-segmented-button/segmented-button/_segmented-button.scss
Outdated
Show resolved
Hide resolved
abhiomkar
approved these changes
Jul 23, 2020
packages/mdc-segmented-button/segmented-button/_segmented-button.scss
Outdated
Show resolved
Hide resolved
abhiomkar
changed the title
abhiomkar
reviewed
Jul 23, 2020
abhiomkar
reviewed
Jul 23, 2020
abhiomkar
reviewed
Jul 24, 2020
add sass classes I currently have to display button TODO: refactor to mixins, accessibility, dark mode, rtl
Add base styles and theme mixins
fix wrong class names and add dependencies to package.json
update my local linter to match project's linter
put sass mixins and classes into files based on go/material-sass-style
remove 'mdc' from file names and fix references
add feature-targeting to control css to emit
fix lint style test and remove feature-targeting-mixins reference to fix build
move sass into different mixins with no change to functionality
put theme mixins into their own file with variables per new SASS style guide
make tests pass
allow for client use of the sass themes
move mixins locations and refactor to avoid pointless modularity
add default $query argument value and pass $query argument instead of feature-target
base mixins are not theme mixins
replace button mixins with copied segment-theme mixins
fix lint and dependency tests
use new API due to custom alpha values
remove button dependency, fix lint errors, correct bad variable references
visible is not a property of border-right
make mixins accept only primitives as input
add mixins for client to use theming without referencing css classes
use unique css properties for different mixins
use new theme/color mixin and clean up use of feature-targeting mixins, and remove ability to have different selected vs unselected outline colors
add comments for SassDoc, and change " to ' in imports
update to reflect change in file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add base styles and theme mixins