enhancement: #500 Flag for the ScrollSpy component that ensures the last active element remains visible + animationDuration option #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanPostu
force-pushed
the
enhancement-500
branch
from
0b5149b
to
2e4ec57
Compare
|
Nice, your video explaines it very clearly 👍 i will review the code tomorrow. |
wuda-io
reviewed
Sep 10, 2024
src/scrollspy.ts
Outdated
Comment on lines
304
to
330
|
|
||
| function getDistanceToViewport(element) { | ||
| const rect = element.getBoundingClientRect(); | ||
| const distance = rect.top; | ||
| return distance; | ||
| } | ||
|
|
||
| function smoothScrollIntoView(element, duration = 300) { | ||
| const targetPosition = element.getBoundingClientRect().top + (window.scrollY || window.pageYOffset); | ||
| const startPosition = (window.scrollY || window.pageYOffset); | ||
| const distance = targetPosition - startPosition; | ||
| const startTime = performance.now(); | ||
|
|
||
| function scrollStep(currentTime) { | ||
| const elapsed = currentTime - startTime; | ||
| const progress = Math.min(elapsed / duration, 1); | ||
| const scrollY = startPosition + distance * progress; | ||
|
|
||
| if (progress < 1) { | ||
| window.scrollTo(0, scrollY); | ||
| requestAnimationFrame(scrollStep); | ||
| } else { | ||
| window.scrollTo(0, targetPosition); | ||
| } | ||
| } | ||
| requestAnimationFrame(scrollStep); | ||
| } |
There was a problem hiding this comment.
i think this two functions should be inside of the class. The rest looks nice!
Can you place them as private functions, then i will merge. Thanks
IvanPostu
changed the title
wuda-io
approved these changes
Nov 13, 2024
|
Please use more descriptive commit messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #500
Proposed changes
Screenshots (if appropriate) or codepen:
Demo Video
Types of changes
Checklist: