Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media queries not triggered at breakpoints on Firefox with display scaling enabled #91

Closed
warrenrodrigues opened this issue Mar 24, 2021 · 0 comments · Fixed by #95
Closed
Labels
bug Something isn't working css/sass For something that related to styling/view

Comments

@warrenrodrigues
Copy link

Current Behavior

CSS media queries are not triggered at exactly the responsive breakpoints (601px, 993px, 1201px) on Mozilla Firefox (latest) on Windows 10 with Display Scaling other than 100% (my display is at 125%.)

This is not specifically a Materialize issue, but needs attention. Bootstrap applied a fix some years ago.

Here is a simple Codepen to understand the issue and here is a detailed blog post to further understand the issue (screenshots included.)

There are also minor inconsistencies with min-width set to 600px (instead of 601px) in some places in the following files

  • ./materialize/sass/components/_global.scss
  • ./materialize/sass/components/_typography.scss

Possible Solution

I have forked the project and have the following fixes ready. I can submit a PR.

  1. Set the min-width to integers, but change the max-width to a fraction (600.99px, 992.99px, 1200.99px)
  2. Fix the variables in the above 2 files.
@Smankusors Smankusors added bug Something isn't working css/sass For something that related to styling/view labels Mar 26, 2021
@Smankusors Smankusors linked a pull request Mar 26, 2021 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working css/sass For something that related to styling/view
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants