[Feature Request]: Pylint alerts corrections as part of an intervention experiment

[evidencebp]

Problem

I'd like to conduct a software engineering experiment regarding the benefit of Pylint alerts removal.
The experiment is described here.
In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control.
After the interventions are done, one can wait and examine the results.

I'm asking for your approval for conducting an intervention in your repository.

See examples of interventions in stanford-oval/storm, gabfl/vault, and coreruleset/coreruleset.

You can see the planed interventions

May I do the interventions?

Proposed Solution

I'll fix the alerts.

Alternatives

Leave code as is.

[tschaume]

Thanks for reaching out! Yes, feel free to go ahead.

[evidencebp]

@tschaume , I created a PR with most fixes.

Plesea note the following (also written in the PR):
In mpcontribs-portal\mpcontribs\users\redox_thermo_csp\pre_submission.py I modified the method run since it had too-many-statments alerts.
Please note that the end of the method was not reachable (and still so) due to a break, which might be a bug.
I added a TODO there to mark that.

There were broad-exception-caught alerts in some files.
Such handling (e.g., catching Exception) might hide bugs due to unexpected exception.
Therefore it is recommended to catch sepcific exceptions.
I could not understand whare are the expected exceptions in few of the cases.
Therefore, I did not fix these alerts yet.
Can you help me with that?

mpcontribs-portal\mpcontribs\portal\views.py
Line 490 in make_download catches Exception

mpcontribs-ingester\mpcontribs\ingester\webui.py
Line 184 in view catches Exception
Line 242 in contribute catches Exception

mpcontribs-serverless\make_download\app.py
Line 60 in lambda_handler catches Exception

mpcontribs-client\mpcontribs\client_init_.py
Line 371 method display in class Table

[evidencebp]

Sorry, I commented here instead of a different repository.