Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to next atomate2 release #721

Closed
13 tasks done
utf opened this issue Feb 15, 2024 · 9 comments
Closed
13 tasks done

Path to next atomate2 release #721

utf opened this issue Feb 15, 2024 · 9 comments

Comments

@utf
Copy link
Member

utf commented Feb 15, 2024

Currently we are stuck in dependency hell which is preventing a new release of atomate2. I've setup this issue to track the various PR's and dependency releases needed to get a new version out.

These are the essential fixes. If there are any other PRs people would like to prioritise for the next release then please let me know. Currently, I'm also tracking the following PRs which are less critical/should be mergeable once the above are completed:

In the meantime, it is recommended to install atomate2 with the strict dependency selection, which is guaranteed to give a working installation.

pip install atomate2[strict]
@utf
Copy link
Member Author

utf commented Feb 15, 2024

@janosh would you be ok to release a new pymatgen version?

@janosh
Copy link
Member

janosh commented Feb 15, 2024

@utf sure, i'll take a look at custodian first though. i forgot why the release failed but it was on my todo list to fix

@utf
Copy link
Member Author

utf commented Feb 15, 2024

Thank you! It's much appreciated.

@janosh
Copy link
Member

janosh commented Feb 15, 2024

so it looks like the release failed because the test.yml and release.yml workflows use different setups. the latter installs openbabel through miniconda, the former doesn't. as a result only a subset of tests are running on PRs but the full test suite when trying to make release. not sure when it became this way

@janosh
Copy link
Member

janosh commented Feb 15, 2024

custodian==v2024.2.15 is now on PyPI.

@utf
Copy link
Member Author

utf commented Feb 15, 2024

Fantastic, thanks @janosh.

@mkhorton
Copy link
Member

would you be ok to release a new pymatgen version?

This has now been done too.

@utf
Copy link
Member Author

utf commented Feb 21, 2024

Brilliant thank you. We're just waiting on a new emmet-core release.

@utf
Copy link
Member Author

utf commented Feb 29, 2024

Thanks for all your help. Atomate v0.0.14 has now been released.

@utf utf closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants