Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Giant white box display Glitch when sorting books by start date/finish date. #451

Closed
ajensen1234 opened this issue Feb 6, 2024 · 9 comments · Fixed by #452, #492 or #519
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ajensen1234
Copy link

Describe the bug
A clear and concise description of what the bug is.
A white box fills the entire screen when you try and sort books by start/finish date. It seems to be of infinite size, because you cannot scroll beyond it. It remains even after deleting storage and importing data as both a full import and just a csv, so it must not have anything to do with the covers. It only effects certain books, not all.

To Reproduce
Steps to reproduce the behavior:
Install release 2.4 from GitHub (obtanium).
Import books
Sort by start/finish date.

Expected behavior
A clear and concise description of what you expected to happen.
I expected to see the normal pages as they've always been present.

Screenshots
If applicable, add screenshots to help explain your problem.Screenshot_20240206-073440.png
Screenshot_20240206-073956.png
Screenshot_20240206-073932.png

Additional info(please complete the following information):

  • App version: 2.4.0
  • App source (F-Droid, Google Play, Github, AppStore): GitHub (via obtanium)
  • Manufacturer and model: Google Pixel 7 Pro
  • OS and version: GrapheneOS, 2024012600

Additional context
Add any other context about the problem here.

@ajensen1234 ajensen1234 added the bug Something isn't working label Feb 6, 2024
@mateusz-bak
Copy link
Owner

Thanks for reporting, I observed the same and doing the fix now

@mateusz-bak mateusz-bak linked a pull request Feb 6, 2024 that will close this issue
@mateusz-bak
Copy link
Owner

Should be fixed in 2.4.1

@ajensen1234
Copy link
Author

Thanks a ton! I appreciate all your work on this outstanding app!

@smlpt
Copy link

smlpt commented Feb 16, 2024

Hey @mateusz-bak, I fear this is not quite solved yet.
I downloaded 2.4.1 today, added a second start reading date to a book and changed it to "in progress":

As soon as I add a finish date, the grey box is gone. It also only happens when the sort order includes the date.

It gets even worse when you move the book to "finished" without adding an end reading date:

This basically makes the whole list/grid view unclickable and right now the only temporary solution is to not use either the start or finish date for the sort order.

@mateusz-bak mateusz-bak reopened this Feb 17, 2024
@mateusz-bak
Copy link
Owner

Thanks @smlpt will work on this today

@mateusz-bak
Copy link
Owner

The code was getting the latest start/finish date by going through all readings.

If the reading would not have start or finish date set it would crash.
Now it goes only through the readings that have finish or start date set when needed.

I think this will work now and will be released in 2.5.1

@smlpt
Copy link

smlpt commented Feb 19, 2024

Thank you!

@ajensen1234
Copy link
Author

@mateusz-bak this issue has come back for me, unfortunately, in 2.5.1 :(

Screenshot_20240228-171835.png

Screenshot_20240228-171832.png

@mateusz-bak
Copy link
Owner

mateusz-bak commented Mar 2, 2024

Okay, I reproduced it now and found one more issue, fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment