Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Paginator not added to polymorphic serializer #89

Closed
3 tasks
janders4 opened this issue Apr 19, 2024 · 1 comment · Fixed by #90
Closed
3 tasks

[BUG] Paginator not added to polymorphic serializer #89

janders4 opened this issue Apr 19, 2024 · 1 comment · Fixed by #90
Assignees
Labels
bug Something isn't working

Comments

@janders4
Copy link
Contributor

Describe the bug*

Pagination links are not being added to the data document.

To Reproduce*

Use the polymorphic serialiser and pass in a Paginator as part of the options but do not include options.linkers.document

Expected behavior*

Pagination links should be included when provided

Screenshots

This is the logic that appears to be the problem. The paginator will only ever be added when options.linkers.document exists
Screenshot 2024-04-19 at 09 13 03

Platform*

  • OS: macOS Sonoma 14.3.1
  • Browser N/A
  • Version: 1.11.2
@janders4 janders4 added the bug Something isn't working label Apr 19, 2024
@janders4
Copy link
Contributor Author

@jun-sheaf can you assign this to me please. I'll submit a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants