Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement users.delete RPC function #4000

Closed
Tracked by #3993
mathemancer opened this issue Nov 1, 2024 · 3 comments · Fixed by #4026
Closed
Tracked by #3993

Implement users.delete RPC function #4000

mathemancer opened this issue Nov 1, 2024 · 3 comments · Fixed by #4026
Milestone

Comments

@mathemancer
Copy link
Contributor

mathemancer commented Nov 1, 2024

We need to implement a users.delete RPC function to replace the DELETE /api/ui/v0/users/{userId}/ endpoint.

The function signature should be:

@rpc_method(name='users.delete')
@http_basic_auth_superuser_required
@handle_rpc_exceptions
def delete(
        *,
        user_id: int,
) -> None:

See the wiki for more context.

@nilaygit-10721
Copy link

Hello @mathemancer , could you please guide me to the specific file or directory where I should implement the users.delete RPC function as outlined? I want to ensure I'm working in the right section of the codebase. Thank you!

@mathemancer
Copy link
Contributor Author

For the back end portion, you'll need to look in the mathesar/api/rpc/ directory. You need to create a new file mathesar/api/rpc/users/base.py for this, since it's the first users namespace RPC function.

@nilaygit-10721
Copy link

check my pr #4014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants