Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WL Function Collect[] (Sympy collect) #1194

Open
rocky opened this issue Mar 21, 2021 · 3 comments
Open

Add WL Function Collect[] (Sympy collect) #1194

rocky opened this issue Mar 21, 2021 · 3 comments

Comments

@rocky
Copy link
Member

rocky commented Mar 21, 2021

@rocky rocky changed the title Add WL Collect (Sympy collect) Add WL Function Collect[] (Sympy collect) Mar 21, 2021
@rocky rocky mentioned this issue Mar 25, 2021
Open
@mmatera
Copy link
Contributor

mmatera commented Apr 26, 2021

Implemented in PR #1320.

@TiagoCavalcante
Copy link
Contributor

@rocky what still needs to be done?

@mmatera
Copy link
Contributor

mmatera commented Jun 29, 2021

@TiagoCavalcanteTrindade, this came up when we notice that Collect was not implemented. I tried to use the sympy's Collect, but it does not work. So, I made a basic native implementation. I think we left this because that implementation had some issues, but I do not remember. Maybe it worth it to write some extra tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rocky @mmatera @TiagoCavalcante