Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support one line headers #434

Open
Rots opened this issue Dec 9, 2022 · 5 comments
Open

Support one line headers #434

Rots opened this issue Dec 9, 2022 · 5 comments
Labels
in:core MLP core module is:feature New feature todo Accepted items from the backlog which can be worked on

Comments

@Rots
Copy link

Rots commented Dec 9, 2022

Describe the feature

I'd like to add one liners, but the current custom configuration won't allow that complaining that firstLine and lastLine cannot be empty
e.g.

<!-- Copyright XYZ 2022 -->               # in .html
// Copyright XYZ 2022                     # in .ts

Any alternative you've considered ?
a) live with multi line
b) not using this tool

@Rots Rots added the is:feature New feature label Dec 9, 2022
@Rots
Copy link
Author

Rots commented Dec 9, 2022

I found

https://github.com/mathieucarbou/license-maven-plugin/blob/license-maven-plugin-4.2.rc3/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/header/HeaderType.java#L43

and

https://github.com/mathieucarbou/license-maven-plugin/blob/license-maven-plugin-4.2.rc3/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/header/HeaderType.java#L59

the first still adds blank lines before and after the comment, in some cases the first tag gets lost :/
the second mostly works, but other comments at the beginning of the file are also removed :(
I would also need the single line alternatives to all other cases like /** this */

@stale
Copy link

stale bot commented Feb 8, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Inactive items that will be automatically closed if not resurrected label Feb 8, 2023
@Rots
Copy link
Author

Rots commented Feb 8, 2023

Yes, still relevant, but no progress has been made

@mathieucarbou
Copy link
Owner

@Rots : did you try to make your own header template definition ?

@mathieucarbou mathieucarbou added is:support Support, help or questions todo Accepted items from the backlog which can be worked on and removed stale Inactive items that will be automatically closed if not resurrected labels Feb 14, 2023
@Rots
Copy link
Author

Rots commented Feb 14, 2023

Yes, but like I mentioned:

I'd like to add one liners, but the current custom configuration won't allow that complaining that firstLine and lastLine cannot be empty

@mathieucarbou mathieucarbou added in:core MLP core module and removed is:support Support, help or questions labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:core MLP core module is:feature New feature todo Accepted items from the backlog which can be worked on
Projects
None yet
Development

No branches or pull requests

2 participants