ENH - add warning in PN_logreg for unhandled case
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badr-MOUFAD
commented
Apr 24, 2022
| @@ -400,11 +400,12 @@ cpdef void do_line_search( | |||
| floating[::1, :] X, floating[:] X_data, | |||
| int[:] X_indices, int[:] X_indptr, int MAX_BACKTRACK_ITR, | |||
| floating[:] y, floating[:] exp_Xw, floating[:] low_exp_Xw, | |||
| floating[:] aux, int[:] is_positive_label) nogil: | |||
| floating[:] aux, int[:] is_positive_label): | |||
There was a problem hiding this comment.
I think not releasing the GIL here won't affect the performance as this function is originally single-threaded.
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 14 14
Lines 998 998
Branches 131 131
=======================================
Hits 868 868
Misses 100 100
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #240