Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in code core/types/tx_dynamic_fee.go #1047

Closed
brainswa opened this issue Oct 16, 2023 · 3 comments · Fixed by #1064
Closed

typo in code core/types/tx_dynamic_fee.go #1047

brainswa opened this issue Oct 16, 2023 · 3 comments · Fixed by #1064
Assignees

Comments

@brainswa
Copy link

return tx.gasTipCapUint256

func (tx *DynamicFeeTx) gasPriceU256() *uint256.Int {
	if tx.gasFeeCapUint256 != nil {
		// return tx.gasTipCapUint256
		return tx.gasFeeCapUint256
	}

	tx.gasFeeCapUint256, _ = uint256.FromBig(tx.GasFeeCap)

	return tx.gasFeeCapUint256
}
@pratikspatil024
Copy link
Member

Hi @brainswa - can you please explain a bit more?

@brainswa
Copy link
Author

@pratikspatil024 function gasPriceU256 need to return tx.gasFeeCapUint256, instead that it's return gasTipCapUint256 when the value has already cached

@0xsharma 0xsharma self-assigned this Oct 30, 2023
@0xsharma 0xsharma linked a pull request Oct 30, 2023 that will close this issue
@0xsharma
Copy link
Contributor

Thank you @brainswa for bringing this to light! We have merged the fix and should be included in upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants