Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The effect causes KWin to paint the area behind opaque windows, resulting in higher GPU usage #207

Open
taj-ny opened this issue Apr 17, 2024 · 2 comments
Labels
help wanted Extra attention is needed wontfix This will not be worked on

Comments

@taj-ny
Copy link

taj-ny commented Apr 17, 2024

With just a few blurred windows in the background, the regions that have to be painted quickly add up, even if all the windows are covered by an opaque window.

I believe this is an accident, as data.setTranslucent() sets data.opaque to an empty region, but just a few lines later you are subtracting from that empty region.
https://github.com/matinlotfali/KDE-Rounded-Corners/blob/master/src/ShapeCornersEffect.cpp#L137-L149
https://github.com/KDE/kwin/blob/v6.0.3/src/effect/effect.cpp#L20-L25

I commented out the data.setTranslucent() line and the GPU usage has dropped in the situation described at the beginning. I haven't noticed any issues with corners, shadows or the outline on Wayland and X11.

Although I should mention that Plasma 6 broke transparent color schemes and the translucent area behind some windows is no longer painted (bug report, video), resulting in artifacts on Wayland. data.setTranslucent() does fix this, so removing it could bring back the issue for some users.

I'm running Plasma 6.0.3 with KDE-Rounded-Corners 0.6.1.

@matinlotfali
Copy link
Owner

You are absolutely correct. The setTranslucent is there only because of the ugly artifacts. I should have written comments in the code about it.

@matinlotfali
Copy link
Owner

Sadly, I don't know how else I can prevent the artifact. I am open for suggestions.

@matinlotfali matinlotfali added help wanted Extra attention is needed wontfix This will not be worked on labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants