Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left menu on iOS misplaced when you open it in portrait mode and then change it to landscape. #5449

Open
tsteur opened this issue Mar 16, 2023 · 4 comments
Labels

Comments

@tsteur
Copy link
Member

tsteur commented Mar 16, 2023

image

I tried fixing this for 2 hours, including using ListViews etc but couldn't work around it. It partially works when using extendSafeArea:true on the left menu window, but then the labels have a huge padding/margin to the left. The labels start where the round corners of the phone is no longer there.
image

@tsteur tsteur added the bug label Mar 16, 2023
@m1ga
Copy link
Contributor

m1ga commented Mar 16, 2023

a very quick fix would be:
https://github.com/matomo-org/matomo-mobile-2/blob/master/app/styles/report_chooser_row.tss#L21
left: -40 but only for landscape right (camera on the right). But I don't mind it looking like this as is has the same distance as holding it the other way round (camera on the left).

@m1ga
Copy link
Contributor

m1ga commented Mar 16, 2023

You can use safeAreaPadding to get the correct width (its 57) but -40 will look fine

@tsteur
Copy link
Member Author

tsteur commented Mar 16, 2023

Got it. Thanks for that @m1ga I didn't realise we're able to use negative values there

@m1ga
Copy link
Contributor

m1ga commented Mar 16, 2023

btw: I'm not 100% sure why it doesn't extend if you add extendSafeArea:true I thought it would remove them on both sides:
safe-areas-1

edit:
perhaps defining the edges would help https://titaniumsdk.com/api/titanium/ui/ios/navigationwindow.html#properties_extendedges
but I've never used that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants