Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XYShapeAnnotation support #49

Closed
matoos32 opened this issue Nov 7, 2022 · 1 comment · Fixed by #68
Closed

Add XYShapeAnnotation support #49

matoos32 opened this issue Nov 7, 2022 · 1 comment · Fixed by #68
Assignees
Labels
enhancement New feature or request

Comments

@matoos32
Copy link
Owner

matoos32 commented Nov 7, 2022

No description provided.

@matoos32 matoos32 added the enhancement New feature or request label Nov 7, 2022
@matoos32 matoos32 self-assigned this Nov 23, 2022
@matoos32
Copy link
Owner Author

This one is hitting a road block. For gapless charts we need to somehow map the java.awt.Shape's time coordinate to x-coordinates as indices in time arrays for use in NumberAxis, but Shape is an interface and concrete classes can have any number of x-coordinates passed-in and in any number of ways. The interface provides no means to get shape coordinates polymorphically. So it requires specific logic for 30+ different known implementing classes. See https://docs.oracle.com/javase/8/docs/api/java/awt/Shape.html.

That is a big effort possibly warranting a ticket for each and with high maintenance burden. It's also unclear how much demand there is for these capabilities at all in the builder framework.

So I'm going to merge the implementation for DateAxis ("with gap") charts where in that context it's a general solution for shape annotations.

The implementation for NumberAxis ("gapless") will be left as unsupported but as a TODO to be figured out if there's enough community demand for it. Support for specific Shapes can be added on a case-by-case basis while thinking about how to add them all in.

I know this is not ideal but it's the best I can do within my time constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant